Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#7] Replace handlebars with handlebars-engine #24

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

gi
Copy link
Owner

@gi gi commented Jan 31, 2022

This updates the Handlebars engine to remove any dependency on therubyracer.
The handlebars-engine gem uses the mini_racer gem instead.

See https://github.com/gi/handlebars-ruby
See https://rubygems.org/gems/handlebars-engine

Fixes #7.

@codeclimate
Copy link

codeclimate bot commented Jan 31, 2022

Code Climate has analyzed commit 7a1e4ab and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 98.5% (0.0% change).

View more on Code Climate.

This updates the Handlebars engine to remove any dependency on `therubyracer`.
The `handlebars-engine` gem uses the `mini_racer` gem instead.

See https://github.com/gi/handlebars-ruby
See https://rubygems.org/gems/handlebars-engine

Fixes #7.
@gi gi force-pushed the issue-7/use-handlebars-engine branch from cc1e04c to 7a1e4ab Compare January 31, 2022 19:55
@gi gi merged commit 2fd9952 into develop Jan 31, 2022
@gi gi deleted the issue-7/use-handlebars-engine branch January 31, 2022 19:56
gi added a commit that referenced this pull request Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecating therubyracer for mini_racer
1 participant