-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move packages/ui into the main source #1897
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalluban
force-pushed
the
fix-move-packages-ui
branch
from
September 24, 2024 14:08
453b82b
to
1b7e34f
Compare
chrmod
previously approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've scan the changes and all looks good. The PR could have been smaller if you would decide tho keep the previous naming scheme with gh-
prefix.
We have to test the changes manually to be sure all if fine.
smalluban
force-pushed
the
fix-move-packages-ui
branch
from
September 26, 2024 08:49
4cb486d
to
218e89a
Compare
smalluban
force-pushed
the
fix-move-packages-ui
branch
from
September 26, 2024 08:49
218e89a
to
4488d10
Compare
Builds for commit 4488d10: |
philipp-classen
approved these changes
Sep 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all of the modules of
packages/ui
into the main source:global
into thesrc/ui
, other modules into the specific pages, where they were usedui/styles.css
loaded automatically with theui
moduleui-
, page components with page name prefix, likeonboarding-
orsettings-
I did all of the smoke tests on Firefox and Chrome. However, the PR contains mainly visual changes, so please check out the package too when reviewing.