Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move packages/ui into the main source #1897

Merged
merged 9 commits into from
Sep 26, 2024
Merged

Conversation

smalluban
Copy link
Collaborator

@smalluban smalluban commented Sep 23, 2024

Moves all of the modules of packages/ui into the main source:

  • Module global into the src/ui, other modules into the specific pages, where they were used
  • Unifies the panel/onboarding styling into a single ui/styles.css loaded automatically with the ui module
  • Unifies component naming prefixes - global component with ui-, page components with page name prefix, like onboarding- or settings-
  • Minor fixes to the global components - missing hover states, cleared font sizing, etc

I did all of the smoke tests on Firefox and Chrome. However, the PR contains mainly visual changes, so please check out the package too when reviewing.

@smalluban smalluban marked this pull request as ready for review September 26, 2024 07:17
@smalluban smalluban added the package CI: create extension packages label Sep 26, 2024
@ghostery ghostery deleted a comment from github-actions bot Sep 26, 2024
chrmod
chrmod previously approved these changes Sep 26, 2024
Copy link
Member

@chrmod chrmod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've scan the changes and all looks good. The PR could have been smaller if you would decide tho keep the previous naming scheme with gh- prefix.
We have to test the changes manually to be sure all if fine.

Copy link

@ghostery ghostery deleted a comment from github-actions bot Sep 26, 2024
@ghostery ghostery deleted a comment from github-actions bot Sep 26, 2024
@smalluban smalluban merged commit 9522f3f into main Sep 26, 2024
2 checks passed
@smalluban smalluban deleted the fix-move-packages-ui branch September 26, 2024 10:22
@smalluban smalluban mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package CI: create extension packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants