Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR adds E2E testing for adblockers:
adblocker-puppeteer
,adblocker-playwright
,adblocker-electron
, andadblocker-webextension
. The motivation of adding E2E testing comes from the replace modifier support. I found that implementing an E2E test to adblocker library doesn't make sense because adblocker library itself doesn't represent or illustrates end-user environment.The tests will end up same as unit tests. Note that not all of adblocker library is implemented due to some challenges:
adblocker-electron
adblocker-webextension
This package itself doesn't represent the webextension.
We'll need to prepare a complete adblocker implementation for this.
We may use
adblocker-webextension-example
but it's still at the open discussion.Approach