Parse diagnostic(…) attributes on fns
#6353
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
1. Break out `word_as_ident*` helpers to keep validation of identifiers DRY. 2. Add `peek_*` variants. TODO: Pending validation from @jimb at <https://matrix.to/#/!fjjkgHFcwtkREywzfk:matrix.org/$feC_32iRis6rk0hiqm-gysIzljXNSfVmbNTBJAjlhKY?via=matrix.org&via=mozilla.org&via=ralith.com>
This resolves ambiguity that will be introduced in the subsequent commit that adds `impl From<ConflictingDiagnosticRuleError> for naga::Error`.
ErichDonGubler
force-pushed
the
erichdongubler/push-xlypklnukzlu
branch
from
bf4eab8
to
a954d89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
diagnostic(…);directives #6148.diagnostic(…)) #5320.Description
Building on #6148, we use all of the plumbing we made for tracking diagnostic rules, and add a parse path for
@diagnostic(…) fn function() { … }. After #6148, this PR's parse path is what I've observed to be the next most common place for users to apply diagnostic filtering.Testing
Tests will be added to this PR before it comes out of draft.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.