Add a skeleton for directives that reports nice errors #6352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
ErichDonGubler
force-pushed
the
erichdongubler/push-nzmmrzzmyvqu
branch
from
0994648
to
2d56bab
Compare
1. Break out `word_as_ident*` helpers to keep validation of identifiers DRY. 2. Add `peek_*` variants. TODO: Pending validation from @jimb at <https://matrix.to/#/!fjjkgHFcwtkREywzfk:matrix.org/$feC_32iRis6rk0hiqm-gysIzljXNSfVmbNTBJAjlhKY?via=matrix.org&via=mozilla.org&via=ralith.com>
ErichDonGubler
force-pushed
the
erichdongubler/push-nzmmrzzmyvqu
branch
from
2d56bab
to
b0c008b
Compare
ErichDonGubler
commented
Oct 4, 2024
Comment on lines
+2492
to
+2496
| return Err(Error::DirectiveNotYetImplemented { | ||
| kind: name, | ||
| span: ident.span, | ||
| tracking_issue_num: unimplemented.tracking_issue_num(), | ||
| }) |
There was a problem hiding this comment.
nitpick: I think I should consolidate the kind (&str) and tracking_issue_num fields into an kind of the unimplemented enum. The &str and u16 can be derived from the enum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Dependency of #6148.
May conflict with changes in #5701. If this merges first, I'll resolve conflicts there.
Lays groundwork for:
enabledirective #5476diagnostic(…);directives #6148requiresdirective #6350Description
There's not a parse path for any directives, let alone what I'm working on in #6148. It turns out that adding the starting point with some diagnostics is enough code that a PR checkpoint sounds wise.
Testing
Tests will be added before this PR comes out of draft, to ensure that the error cases added here are covered.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.