Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let the "strict_asserts" feature enable Token::root assertions. #4258

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Let the "strict_asserts" feature enable Token::root assertions. #4258

merged 1 commit into from
Oct 18, 2023

Conversation

jimblandy
Copy link
Member

@jimblandy jimblandy commented Oct 18, 2023 •
edited
Loading

Perform run-time checks that only one root Token exists per thread when the "strict_asserts" feature is enabled, not only in debug builds.

Checklist

  • Run cargo clippy.
  • Run cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@jimblandy jimblandy requested a review from a team as a code owner October 18, 2023 01:01
@jimblandy
Let the "strict_asserts" feature enable Token::root assertions.
669d159 
Perform run-time checks that only one root `Token` exists per thread
when the `"strict_asserts"` feature is enabled, not only in debug
builds.
@jimblandy jimblandy force-pushed the token-assertions-strict-asserts branch from 16c4137 to 669d159 Compare October 18, 2023 01:03
@jimblandy jimblandy mentioned this pull request Oct 18, 2023
Merged
1 task
cwfitzgerald
cwfitzgerald approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not terribly happy about the extra cfg, but not sure of a way around it.

@cwfitzgerald cwfitzgerald merged commit da0b3fe into gfx-rs:trunk Oct 18, 2023
23 checks passed
@jimblandy jimblandy deleted the token-assertions-strict-asserts branch December 13, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimblandy @cwfitzgerald