Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add publish pypi github action #56

Merged
merged 5 commits into from
Sep 13, 2023
Merged

add publish pypi github action #56

merged 5 commits into from
Sep 13, 2023

Conversation

hsiehkl
Copy link
Contributor

@hsiehkl hsiehkl commented Sep 7, 2023 •
edited
Loading

Description

[UPDATE] use PYPI_DB_ROCKET

@jeanCarloMachado can you add PYPI_TOKEN for this project? Are there any reasons we didn't publish new versions of this project?

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed

Added to documentation?

  • 👍 README.md
  • 👍 CHANGELOG.md
  • 👍 Additional documentation in /docs
  • 👍 Relevant code documentation
  • 🙅 no, because they aren’t needed

@hsiehkl hsiehkl requested a review from a team as a code owner September 7, 2023 13:46
steven-mi
steven-mi approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@steven-mi steven-mi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsiehkl hsiehkl merged commit ac867d6 into main Sep 13, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-mi steven-mi steven-mi approved these changes

@jeanCarloMachado jeanCarloMachado Awaiting requested review from jeanCarloMachado

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsiehkl @steven-mi