-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jabref: Update to 5.15 along with packaging fixes #3605
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it's including a bundled version of Java in the package. I don't think that's what we want to do.
Yes. I think you are right. I see that now. i'll see what I can do. |
packages/j/jabref/package.yml
Outdated
-PprojVersion=$version \ | ||
assemble | ||
gradle assemble --no-daemon --no-build-cache -PprojVersionInfo=$version -PprojVersion=$version | ||
gradle jlink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a point in using gradle jlink
. That builds a distribution for jabref which includes the openjdk (so you can use it without java installed), but that's not really desirable for us since that openjdk is built from whatever the openjdk version was at the build time but if we update openjdk then jabref will still be using an old openjdk until it's rebuilt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I agree. I have a new build that does not use that, but I have not been able update the PR yet due to some other issues. I will try to that soon for your review.
**Summary** - Update from 5.5 to 5.15 [changelogs](https://github.com/JabRef/jabref/releases) - Add homepage to package.yml - Update to openjdk-21 - Include new MAINTAINERS.md - Include monitoring.yml - Include appstream metainfo - Resolves (getsolus#3086) - Resolves (getsolus#2642)
2765637
to
be07105
Compare
Summary
Update from 5.5 to 5.15 changelogs
Add homepage to package.yml
Update to openjdk-21
Include new MAINTAINERS.md
Include monitoring.yml
Include appstream metainfo
Resolves #3089
Resolves #2642
Related to #1389
Test Plan
Checklist