Jabref: Update to 5.15 along with packaging fixes #3605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EbonJaeger
reviewed
Aug 21, 2024
EbonJaeger
requested changes
Aug 22, 2024
|
Yes. I think you are right. I see that now. i'll see what I can do. |
ReillyBrogan
requested changes
Sep 13, 2024
packages/j/jabref/package.yml
Outdated
| -PprojVersion=$version \ | ||
| assemble | ||
| gradle assemble --no-daemon --no-build-cache -PprojVersionInfo=$version -PprojVersion=$version | ||
| gradle jlink |
There was a problem hiding this comment.
I don't see a point in using gradle jlink. That builds a distribution for jabref which includes the openjdk (so you can use it without java installed), but that's not really desirable for us since that openjdk is built from whatever the openjdk version was at the build time but if we update openjdk then jabref will still be using an old openjdk until it's rebuilt.
There was a problem hiding this comment.
Yes. I agree. I have a new build that does not use that, but I have not been able update the PR yet due to some other issues. I will try to that soon for your review.
**Summary** - Update from 5.5 to 5.15 [changelogs](https://github.com/JabRef/jabref/releases) - Add homepage to package.yml - Update to openjdk-21 - Include new MAINTAINERS.md - Include monitoring.yml - Include appstream metainfo - Resolves (getsolus#3086) - Resolves (getsolus#2642)
A108384
force-pushed
the
update_jabref
branch
from
2765637
to
be07105
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update from 5.5 to 5.15 changelogs
Add homepage to package.yml
Update to openjdk-21
Include new MAINTAINERS.md
Include monitoring.yml
Include appstream metainfo
Resolves #3089
Resolves #2642
Related to #1389
Test Plan
Checklist