Feature/reconciliation invoices #484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistent naming for log entries
# Conflicts: # cmd/payment-reconciliation/main.go
… CheckPendingOutgoingPayments
|
Something must be wrong here, because this is what we already have in here: https://github.com/getAlby/lndhub.go/blob/main/cmd/payment-reconciliation/main.go |
|
this merge looks wrong: adf8cde I assume that file of the feature branch should have a different name. - it probably was based on the file in the master branch but then changed but the name stayed the same. when you merged master in the branch you used the code from master then. so we should move that in a file with a different name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.