feat: show podcasting info in transactions #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we get rid of the seemingly duplicate "description" & "message" here? Or could they be different? |
|
I think we should change this in the Hub, if the transaction already has the tlv records/boostagram, then it doesn't make sense to change the description of the transaction to the one fetched from tlv records right? Similarly we do this during zap requests made in the rails app, we change the description to the content from the zap... (this is should also be changed I feel) |
reneaaron
force-pushed
the
task-records
branch
2 times, most recently
from
7e557d4
to
5a7afdf
Compare
reneaaron
force-pushed
the
task-records
branch
from
5a7afdf
to
f340165
Compare
reneaaron
reviewed
Oct 17, 2024
|
|
||
| export function Transaction() { | ||
| const { transactionJSON } = useLocalSearchParams() as unknown as { | ||
| transactionJSON: string; | ||
| }; | ||
| const transaction: Nip47Transaction = JSON.parse(transactionJSON); | ||
| const getFiatAmount = useGetFiatAmount(); | ||
| const rawMetadata = transaction.metadata; |
There was a problem hiding this comment.
This part could potentially be memoized. Otherwise the records are parsed with every render...
reneaaron
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16
This adds boostagram tlv record info only. We don't show other info in the Hub, is it worth showing the other custom record information here?
Screenshots