chore: simplify conditional balance display and bitcoin connect store #227
Conversation
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. What is telemetry?This package contains telemetry which tracks how it is used. Most telemetry comes with settings to disable it. Consider disabling telemetry if you do not want to be tracked. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
src/state/store.ts
Outdated
| const supportsGetBalance = | ||
| !!info?.methods && | ||
| info.methods.indexOf('getBalance') > -1 && | ||
| !!provider?.getBalance; |
There was a problem hiding this comment.
does it make sense to make this a function saying, something like?
supports(method) {
return !!info?.methods &&
info.methods.indexOf(method) > -1 &&
!!provider?[method]
}
and maybe even something that we can put in the nwc-sdk?
There was a problem hiding this comment.
Maybe that would be good and actually make the JS SDK even simpler to use. I created an issue here: getAlby/js-sdk#221
There was a problem hiding this comment.
I've moved the property to the suggested supports method in the store for now
Addresses #226 (comment)