fix: read scorer

[bonomat]

With this patch we don't read a historically stored scrorer from disk. It's not ideal, but at least users running into panics when loading the scorer will be able to run the app again

Workaround for #797
fix #797

[holzeis]

@bonomat great, if that fixes the issue 🙂

As we have checked my scorer file was anyways empty, so I guess it doesn't hurt not reading the file from disk?

Are there any big disadvantages of recreating the scorer from scratch every time?

[bonomat]

Are there any big disadvantages of recreating the scorer from scratch every time?

I guess we could run without reading from disc. This means, we will not learn from past payments and only keep an in-memory picture of the network.

[bonomat]

@ reviewers :

1. The first commit fixed the problem for me
2. The second commit might be the better fix but I can't test it because it does not panic anymore.

If we go for the second, let's squash the commits.
I propose to roll out a new version with this asap, because you really can't use the app if this happens to you.

[klochowicz]

I would go for solution 2 - it does not panic anymore, and we're logging potential problems, without sweeping them completely under the rug.

[holzeis]

bors r+

[holzeis]

I propose to roll out a new version with this asap, because you really can't use the app if this happens to you.

@bonomat fyi: https://github.com/get10101/10101/actions/runs/5540939930/jobs/10113681545

[bors]

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• clippy
• e2e-tests
• formatting
• lint-commits
• lint-flutter