-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist spendable outputs generated by LDK #938
Conversation
fn insert_payment(&self, _payment_hash: PaymentHash, _info: PaymentInfo) -> Result<()> { | ||
todo!() | ||
} | ||
fn merge_payment( | ||
&self, | ||
_payment_hash: &PaymentHash, | ||
_flow: PaymentFlow, | ||
_amt_msat: MillisatAmount, | ||
_htlc_status: HTLCStatus, | ||
_preimage: Option<PaymentPreimage>, | ||
_secret: Option<PaymentSecret>, | ||
) -> Result<()> { | ||
todo!() | ||
} | ||
fn get_payment( | ||
&self, | ||
_payment_hash: &PaymentHash, | ||
) -> Result<Option<(PaymentHash, PaymentInfo)>> { | ||
todo!() | ||
} | ||
fn all_payments(&self) -> Result<Vec<(PaymentHash, PaymentInfo)>> { | ||
todo!() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - happy to rebase mine on top of this work tomorrow and then we can merge it together?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
3200da2
to
009837d
Compare
009837d
to
3df219e
Compare
I will "merge" this into #940 via rebase. |
Absorbed by #940. |
Fixes #845.