Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist spendable outputs generated by LDK #938

Closed
wants to merge 1 commit into from

Conversation

luckysori
Copy link
Contributor

Fixes #845.

@luckysori luckysori self-assigned this Jul 12, 2023
Comment on lines +24 to +52
fn insert_payment(&self, _payment_hash: PaymentHash, _info: PaymentInfo) -> Result<()> {
todo!()
}
fn merge_payment(
&self,
_payment_hash: &PaymentHash,
_flow: PaymentFlow,
_amt_msat: MillisatAmount,
_htlc_status: HTLCStatus,
_preimage: Option<PaymentPreimage>,
_secret: Option<PaymentSecret>,
) -> Result<()> {
todo!()
}
fn get_payment(
&self,
_payment_hash: &PaymentHash,
) -> Result<Option<(PaymentHash, PaymentInfo)>> {
todo!()
}
fn all_payments(&self) -> Result<Vec<(PaymentHash, PaymentInfo)>> {
todo!()
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will all be implemented as soon as we merge @da-kami's work on #936.

Copy link
Contributor

@da-kami da-kami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - happy to rebase mine on top of this work tomorrow and then we can merge it together?

Copy link
Contributor

@holzeis holzeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@luckysori luckysori force-pushed the feat/persiste-spendable-outputs-coordinator branch from 3200da2 to 009837d Compare July 13, 2023 01:52
@luckysori luckysori force-pushed the feat/persiste-spendable-outputs-coordinator branch from 009837d to 3df219e Compare July 13, 2023 01:58
@luckysori
Copy link
Contributor Author

I will "merge" this into #940 via rebase.

@luckysori
Copy link
Contributor Author

Absorbed by #940.

@luckysori luckysori closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persist spendable output descriptors generated by LDK in coordinator
3 participants