Share to twitter only

[Restioson]

Use the social_share package to share directly and specifically to twitter instead of opening a general share dialogue. This PR is currently a draft since I haven't been able to test this on the Android emulator due to unrelated problems with its setup.

Fixes #824.

[da-kami]

I tested this on my Pixel and this works like a charm!

When I hit the Share on Twitter button in the 10101 app after successfully opening a position Twitter app comes up directly and I have a pre-filled tweet screen:

---

Some notes:

I used the fix in #901 to deploy to my phone with just run-local-android.
I was unable to use the Pay the invoice with 10101 faucet button - but I am not entirely sure why. When I copied the invoice and directly paid it from the faucet on my machine. The payment then worked and I was able to open a position to test the Share on Twitter changes.

[Restioson]

I am going to give this a last shot at testing on my emulator, otherwise I suppose this is ready for review and then merge. I would really like to be able to test it locally to certify that it works

[Restioson]

I've been digging into this and will report my findings shortly - to expand on what @da-kami said earlier, this is the error when trying to fund using 10101 wallet:

[Restioson]

This works on my end, too! 🎉 If twitter is not installed, it redirects to the twitter.com page open in the browser. This is good to know, too.

[bonomat]

I've been digging into this and will report my findings shortly - to expand on what @da-kami said earlier, this is the error when trying to fund using 10101 wallet:

Welcome to the club 😥 I'm getting the same error locally and I can't get it working anymore.

[bonomat]

This works on my end, too! 🎉 If twitter is not installed, it redirects to the twitter.com page open in the browser. This is good to know, too.

Awesome, if it works. Let's get it in.

[bonomat]

LGTM

[klochowicz]

I've been digging into this and will report my findings shortly - to expand on what @da-kami said earlier, this is the error when trying to fund using 10101 wallet:

are you rebased on top of latest changes? maybe it's time to implement rapid gossip sync 🤔

[Restioson]

When running on desktop, I get this when trying to share with Twitter:

[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: MissingPluginException(No implementation found for method shareTwitter on channel social_share)
#0      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:308:7)
<asynchronous suspension>
#1      SocialShare.shareTwitter (package:social_share/social_share.dart:125:29)
<asynchronous suspension>
#2      TradeScreen.shareTweet (package:get_10101/features/trade/trade_screen.dart:397:5)
<asynchronous suspension>
#3      TradeScreen.createSubmitWidget.<anonymous closure> (package:get_10101/features/trade/trade_screen.dart:386:15)
<asynchronous suspension>

Maybe this is allowable as we are only targeting mobile? A fallback might not be too hard to implement, though...

[Restioson]

Added a fallback to just use the old solution if platform isn't IOS or Android (SocialShare only works on those two).

[holzeis]

@Restioson may I ask you to add a changelog entry for that change? thank you.

[bonomat]

Looks good. Let's go

[bonomat]

@Restioson may I ask you to add a changelog entry for that change? thank you.

I did it for you :)

bors r+

[bors]

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• clippy
• e2e-tests
• formatting
• lint-commits
• lint-flutter

[Restioson]

@Restioson may I ask you to add a changelog entry for that change? thank you.

I did it for you :)

bors r+

Thanks!

[Restioson]

Closing as this has been merged