Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEEDBACK NEEDED] Expand the wallet balance rows properly #1295

Closed
wants to merge 1 commit into from

Conversation

Restioson
Copy link
Contributor

Since updating my flutter, I've been experiencing #1129. This PR restores the expected behaviour, but I don't know how it interacts with older flutter versions. Could someone with an older version (i.e, current behaviour of main is as expected) of flutter please test and make sure this doesn't break anything?

@Restioson Restioson added the question Further information is requested label Sep 13, 2023
@klochowicz
Copy link
Contributor

hey, if it stops you from contributing, it might be worthwhile to try fvm with a locked flutter version? we would all benefit from that!

@Restioson
Copy link
Contributor Author

Not sure what you mean by the stopping from contributing part - but I could do that too! If this doesn't break it for you, though, then we could merge this as well?

@klochowicz
Copy link
Contributor

I haven't tried yet; what I actually noticed is that some other earlier commit of yours bumped the packages and my dart/flutter env tries hard to downgrade them every time 😅 so perhaps fvm would be a good idea to make sure you're on the same version as everyone else!

@Restioson
Copy link
Contributor Author

I haven't tried yet; what I actually noticed is that some other earlier commit of yours bumped the packages and my dart/flutter env tries hard to downgrade them every time 😅 so perhaps fvm would be a good idea to make sure you're on the same version as everyone else!

Oh, I see - I'll do that in another PR then. Sorry, I hadn't realised that 😅 I just listened to the cheerful "an update is available!" message

@klochowicz
Copy link
Contributor

I haven't tried yet; what I actually noticed is that some other earlier commit of yours bumped the packages and my dart/flutter env tries hard to downgrade them every time 😅 so perhaps fvm would be a good idea to make sure you're on the same version as everyone else!

Oh, I see - I'll do that in another PR then. Sorry, I hadn't realised that 😅 I just listened to the cheerful "an update is available!" message

all good, I am still puzzled why flutter doesn't have that by default 🤦🏻‍♂️ it's so much easier to deal with it in for rust with rust-toolchain.toml

@klochowicz
Copy link
Contributor

unfortunately, it's the same behaviour @Restioson - on old flutter version it is still broken.

Which flutter version are you using right now? Has your testing identified any other problems in it?
We might consider upgrading the version everywhere it it works well (it will just become more and more annoying with time).

@bonomat
Copy link
Contributor

bonomat commented Sep 19, 2023

Unfortunately on Flutter Flutter 3.10.6 • channel stable it breaks the expected behavior.

@klochowicz
Copy link
Contributor

Closing in favour of #1333

@klochowicz klochowicz closed this Sep 20, 2023
@klochowicz klochowicz deleted the expand-wallet-header branch September 20, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants