fix(app): Ensure that we only notify listeners when it matters

get10101 · Aug 18, 2023 · 73e3a3a · 73e3a3a
1 parent d8ee300
commit 73e3a3a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/mobile/lib/common/service_status_notifier.dart b/mobile/lib/common/service_status_notifier.dart
@@ -23,10 +23,11 @@ class ServiceStatusNotifier extends ChangeNotifier implements Subscriber {
       FLog.debug(text: "Received event: ${event.toString()}");
       var update = event.field0;
       services[update.service] = update.status;
+
+      notifyListeners();
     } else {
       FLog.warning(text: "Received unexpected event: ${event.toString()}");
     }
-    notifyListeners();
   }
 }
 

diff --git a/mobile/lib/features/trade/order_change_notifier.dart b/mobile/lib/features/trade/order_change_notifier.dart
@@ -31,11 +31,11 @@ class OrderChangeNotifier extends ChangeNotifier implements Subscriber {
       orders[order.id] = order;
 
       sortOrderByTimestampDesc();
+
+      notifyListeners();
     } else {
       FLog.warning(text: "Received unexpected event: ${event.toString()}");
     }
-
-    notifyListeners();
   }
 
   void sortOrderByTimestampDesc() {

diff --git a/mobile/lib/features/trade/position_change_notifier.dart b/mobile/lib/features/trade/position_change_notifier.dart
@@ -52,10 +52,10 @@ class PositionChangeNotifier extends ChangeNotifier implements Subscriber {
           }
         }
       }
+
+      notifyListeners();
     } else {
       FLog.warning(text: "Received unexpected event: ${event.toString()}");
     }
-
-    notifyListeners();
   }
 }