fix: Do not rollover an expired position

We need to provide the current timestamp instead of the position expiry, as it would have been otherwise never eligible for rollover.

coordinator/src/node/rollover.rs

@@ -78,7 +78,9 @@ async fn check_if_eligible_for_rollover(
     if let Some(position) =
         positions::Position::get_open_position_by_trader(conn, trader_id.to_string())?
     {
-        if coordinator_commons::is_in_rollover_weekend(position.expiry_timestamp) {
+        if coordinator_commons::is_in_rollover_weekend(OffsetDateTime::now_utc())
+            && !position.is_expired()
+        {
             let next_expiry = coordinator_commons::calculate_next_expiry(OffsetDateTime::now_utc());
             if position.expiry_timestamp == next_expiry {
                 tracing::trace!(%trader_id, position_id=position.id, "Position has already been rolled over");

coordinator/src/position/models.rs

@@ -74,6 +74,11 @@ pub struct Position {
 }
 
 impl Position {
+    // Returns true if the position is expired
+    pub fn is_expired(&self) -> bool {
+        OffsetDateTime::now_utc() >= self.expiry_timestamp
+    }
+
     /// Calculates the profit and loss for the coordinator in satoshis
     pub fn calculate_coordinator_pnl(&self, quote: Quote) -> Result<i64> {
         let closing_price = match self.closing_price {