Merge pull request #1144 from bonomat/fix/remove-feedback-plugin

fix: remove feedback plugin

.github/workflows/ci.yml

@@ -157,8 +157,13 @@ jobs:
         run: |
           docker-compose up -d
           sleep 10 # We need to give docker a bit of time to startup
+      - name: show disk space before tests
+        run: df -h
       - name: Test containers are up
         run: |
           curl -d '{"address":"bcrt1qylgu6ffkp3p0m8tw8kp4tt2dmdh755f4r5dq7s", "amount":"0.1"}' -H "Content-Type: application/json" -X POST http://localhost:3000/faucet
       - name: Run e2e tests
         run: just e2e --nocapture
+      - name: show disk space after tests
+        if: always()
+        run: df -h

mobile/lib/common/modal_bottom_sheet_info.dart

@@ -25,7 +25,7 @@ class ModalBottomSheetInfo extends StatelessWidget {
               ),
             ),
             clipBehavior: Clip.antiAliasWithSaveLayer,
-            useRootNavigator: false,
+            useRootNavigator: true,
             context: context,
             builder: (BuildContext context) {
               return Container(

mobile/lib/common/settings_screen.dart

@@ -2,9 +2,7 @@ import 'dart:convert';
 import 'dart:io';
 
 import 'package:f_logs/f_logs.dart';
-import 'package:feedback/feedback.dart';
 import 'package:flutter/material.dart';
-import 'package:get_10101/common/feedback.dart';
 import 'package:get_10101/common/scrollable_safe_area.dart';
 import 'package:get_10101/bridge_generated/bridge_definitions.dart' as bridge;
 import 'package:intl/intl.dart';
@@ -173,18 +171,6 @@ class _SettingsScreenState extends State<SettingsScreen> {
               Share.shareXFiles([logFile], text: 'Logs from $now');
             },
             child: const Text("Share logs")),
-        const SizedBox(height: 20),
-        ElevatedButton(
-          child: const Text('Provide feedback'),
-          onPressed: () {
-            try {
-              BetterFeedback.of(context).show(submitFeedback);
-            } on Exception catch (e) {
-              ScaffoldMessenger.of(context).showSnackBar(
-                  SnackBar(content: Text('Failed to share feedback via email app because: $e')));
-            }
-          },
-        ),
       ])),
     );
   }

mobile/lib/features/trade/trade_bottom_sheet.dart

@@ -14,7 +14,7 @@ tradeBottomSheet({required BuildContext context, required Direction direction})
     ),
     clipBehavior: Clip.antiAlias,
     isScrollControlled: true,
-    useRootNavigator: false,
+    useRootNavigator: true,
     context: context,
     builder: (BuildContext context) {
       return SafeArea(

mobile/lib/features/trade/trade_bottom_sheet_confirmation.dart

@@ -34,7 +34,7 @@ tradeBottomSheetConfirmation(
     ),
     clipBehavior: Clip.antiAlias,
     isScrollControlled: true,
-    useRootNavigator: false,
+    useRootNavigator: true,
     context: context,
     builder: (BuildContext context) {
       return SafeArea(

mobile/lib/features/trade/trade_screen.dart

@@ -62,7 +62,7 @@ class TradeScreen extends StatelessWidget {
       WidgetsBinding.instance.addPostFrameCallback((_) async {
         return await showDialog(
             context: context,
-            useRootNavigator: false,
+            useRootNavigator: true,
             barrierDismissible: false, // Prevent user from leaving
             builder: (BuildContext context) {
               return Selector<SubmitOrderChangeNotifier, PendingOrderState>(

mobile/lib/features/wallet/wallet_screen.dart

@@ -1,7 +1,6 @@
 import 'package:flutter/material.dart';
 import 'package:flutter_speed_dial/flutter_speed_dial.dart';
 import 'package:get_10101/common/amount_text.dart';
-import 'package:get_10101/common/global_keys.dart';
 import 'package:get_10101/common/submission_status_dialog.dart';
 import 'package:get_10101/common/value_data_row.dart';
 import 'package:get_10101/features/wallet/seed_screen.dart';
@@ -49,8 +48,8 @@ class _WalletScreenState extends State<WalletScreen> {
       sendPaymentChangeNotifier.pendingPayment!.displayed = true;
       WidgetsBinding.instance.addPostFrameCallback((_) async {
         return await showDialog(
-            context: shellNavigatorKey.currentContext!, // Use the context from the navigatorKey
-            useRootNavigator: false,
+            context: context,
+            useRootNavigator: true,
             builder: (BuildContext context) {
               return Selector<SendPaymentChangeNotifier, PendingPaymentState>(
                 selector: (_, provider) => provider.pendingPayment!.state,

mobile/lib/main.dart

@@ -1,11 +1,9 @@
 import 'dart:convert';
 import 'package:f_logs/f_logs.dart';
-import 'package:feedback/feedback.dart';
 import 'package:firebase_core/firebase_core.dart';
 import 'package:firebase_messaging/firebase_messaging.dart';
 import 'package:flutter_local_notifications/flutter_local_notifications.dart';
 import 'package:flutter/material.dart';
-import 'package:get_10101/common/global_keys.dart';
 import 'package:get_10101/firebase_options.dart';
 import 'package:get_10101/common/channel_status_notifier.dart';
 import 'dart:io';
@@ -57,8 +55,8 @@ import 'package:get_10101/features/wallet/domain/wallet_info.dart';
 import 'package:get_10101/ffi.dart' as rust;
 import 'package:version/version.dart';
 
-final GlobalKey<NavigatorState> _feedbackNavigatorKey =
-    GlobalKey<NavigatorState>(debugLabel: 'feedback');
+final GlobalKey<NavigatorState> _rootNavigatorKey = GlobalKey<NavigatorState>(debugLabel: 'root');
+final GlobalKey<NavigatorState> _shellNavigatorKey = GlobalKey<NavigatorState>(debugLabel: 'shell');
 
 void main() {
   WidgetsBinding widgetsBinding = WidgetsFlutterBinding.ensureInitialized();
@@ -115,11 +113,11 @@ class _TenTenOneAppState extends State<TenTenOneApp> {
       GlobalKey<ScaffoldMessengerState>();
 
   final GoRouter _router = GoRouter(
-      navigatorKey: rootNavigatorKey,
+      navigatorKey: _rootNavigatorKey,
       initialLocation: WalletScreen.route,
       routes: <RouteBase>[
         ShellRoute(
-          navigatorKey: shellNavigatorKey,
+          navigatorKey: _shellNavigatorKey,
           builder: (BuildContext context, GoRouterState state, Widget child) {
             return ScaffoldWithNavBar(
               child: child,
@@ -135,39 +133,39 @@ class _TenTenOneAppState extends State<TenTenOneApp> {
                 GoRoute(
                   path: SendScreen.subRouteName,
                   // Use root navigator so the screen overlays the application shell
-                  parentNavigatorKey: rootNavigatorKey,
+                  parentNavigatorKey: _rootNavigatorKey,
                   builder: (BuildContext context, GoRouterState state) {
                     return const SendScreen();
                   },
                 ),
                 GoRoute(
                   path: SeedScreen.subRouteName,
                   // Use root navigator so the screen overlays the application shell
-                  parentNavigatorKey: rootNavigatorKey,
+                  parentNavigatorKey: _rootNavigatorKey,
                   builder: (BuildContext context, GoRouterState state) {
                     return const SeedScreen();
                   },
                 ),
                 GoRoute(
                     path: CreateInvoiceScreen.subRouteName,
                     // Use root navigator so the screen overlays the application shell
-                    parentNavigatorKey: rootNavigatorKey,
+                    parentNavigatorKey: _rootNavigatorKey,
                     builder: (BuildContext context, GoRouterState state) {
                       return const CreateInvoiceScreen();
                     },
                     routes: [
                       GoRoute(
                         path: ShareInvoiceScreen.subRouteName,
                         // Use root navigator so the screen overlays the application shell
-                        parentNavigatorKey: rootNavigatorKey,
+                        parentNavigatorKey: _rootNavigatorKey,
                         builder: (BuildContext context, GoRouterState state) {
                           return ShareInvoiceScreen(invoice: state.extra as ShareInvoice);
                         },
                       ),
                     ]),
                 GoRoute(
                   path: ScannerScreen.subRouteName,
-                  parentNavigatorKey: rootNavigatorKey,
+                  parentNavigatorKey: _rootNavigatorKey,
                   builder: (BuildContext context, GoRouterState state) {
                     return const ScannerScreen();
                   },
@@ -185,7 +183,7 @@ class _TenTenOneAppState extends State<TenTenOneApp> {
         ),
         GoRoute(
             path: WelcomeScreen.route,
-            parentNavigatorKey: rootNavigatorKey,
+            parentNavigatorKey: _rootNavigatorKey,
             builder: (BuildContext context, GoRouterState state) {
               return const WelcomeScreen();
             },
@@ -232,7 +230,7 @@ class _TenTenOneAppState extends State<TenTenOneApp> {
         if (coordinatorVersion > clientVersion) {
           FLog.warning(text: "Client out of date. Current version: ${clientVersion.toString()}");
           showDialog(
-              context: shellNavigatorKey.currentContext!,
+              context: _shellNavigatorKey.currentContext!,
               builder: (context) => AlertDialog(
                       title: const Text("Update available"),
                       content: Text("A new version of 10101 is available: "
@@ -258,25 +256,24 @@ class _TenTenOneAppState extends State<TenTenOneApp> {
   @override
   Widget build(BuildContext context) {
     MaterialColor swatch = tenTenOnePurple;
-    return BetterFeedback(
-        key: _feedbackNavigatorKey,
-        child: MaterialApp.router(
-          title: "10101",
-          scaffoldMessengerKey: scaffoldMessengerKey,
-          theme: ThemeData(
-            primarySwatch: swatch,
-            iconTheme: IconThemeData(
-              color: tenTenOnePurple.shade800,
-              size: 32,
-            ),
-            extensions: <ThemeExtension<dynamic>>[
-              const TradeTheme(),
-              WalletTheme(colors: ColorScheme.fromSwatch(primarySwatch: swatch)),
-            ],
-          ),
-          routerConfig: _router,
-          debugShowCheckedModeBanner: false,
-        ));
+
+    return MaterialApp.router(
+      title: "10101",
+      scaffoldMessengerKey: scaffoldMessengerKey,
+      theme: ThemeData(
+        primarySwatch: swatch,
+        iconTheme: IconThemeData(
+          color: tenTenOnePurple.shade800,
+          size: 32,
+        ),
+        extensions: <ThemeExtension<dynamic>>[
+          const TradeTheme(),
+          WalletTheme(colors: ColorScheme.fromSwatch(primarySwatch: swatch)),
+        ],
+      ),
+      routerConfig: _router,
+      debugShowCheckedModeBanner: false,
+    );
   }
 
   Future<void> init(bridge.Config config) async {

mobile/macos/Flutter/GeneratedPluginRegistrant.swift

@@ -5,24 +5,20 @@
 import FlutterMacOS
 import Foundation
 
-import device_info_plus
 import firebase_core
 import firebase_messaging
 import flutter_local_notifications
 import package_info_plus
 import path_provider_foundation
 import share_plus
 import shared_preferences_foundation
-import url_launcher_macos
 
 func RegisterGeneratedPlugins(registry: FlutterPluginRegistry) {
-  DeviceInfoPlusMacosPlugin.register(with: registry.registrar(forPlugin: "DeviceInfoPlusMacosPlugin"))
   FLTFirebaseCorePlugin.register(with: registry.registrar(forPlugin: "FLTFirebaseCorePlugin"))
   FLTFirebaseMessagingPlugin.register(with: registry.registrar(forPlugin: "FLTFirebaseMessagingPlugin"))
   FlutterLocalNotificationsPlugin.register(with: registry.registrar(forPlugin: "FlutterLocalNotificationsPlugin"))
   FLTPackageInfoPlusPlugin.register(with: registry.registrar(forPlugin: "FLTPackageInfoPlusPlugin"))
   PathProviderPlugin.register(with: registry.registrar(forPlugin: "PathProviderPlugin"))
   SharePlusMacosPlugin.register(with: registry.registrar(forPlugin: "SharePlusMacosPlugin"))
   SharedPreferencesPlugin.register(with: registry.registrar(forPlugin: "SharedPreferencesPlugin"))
-  UrlLauncherPlugin.register(with: registry.registrar(forPlugin: "UrlLauncherPlugin"))
 }