feat: Disable taking orders when the prices are not available

If there's no bid/ask price, disable the buttons that would react to it.
get10101 · Jul 11, 2023 · 062d498 · 062d498
1 parent 39343ef
commit 062d498
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 11 deletions.
diff --git a/mobile/lib/features/trade/position_change_notifier.dart b/mobile/lib/features/trade/position_change_notifier.dart
@@ -14,7 +14,7 @@ class PositionChangeNotifier extends ChangeNotifier implements Subscriber {
 
   Map<ContractSymbol, Position> positions = {};
 
-  Price? _price;
+  Price? price;
 
   Future<void> initialize() async {
     List<Position> positions = await _positionService.fetchPositions();
@@ -34,8 +34,8 @@ class PositionChangeNotifier extends ChangeNotifier implements Subscriber {
     if (event is bridge.Event_PositionUpdateNotification) {
       Position position = Position.fromApi(event.field0);
 
-      if (_price != null) {
-        final pnl = _positionService.calculatePnl(position, _price!);
+      if (price != null) {
+        final pnl = _positionService.calculatePnl(position, price!);
         position.unrealizedPnl = pnl != null ? Amount(pnl) : null;
       } else {
         position.unrealizedPnl = null;
@@ -45,11 +45,11 @@ class PositionChangeNotifier extends ChangeNotifier implements Subscriber {
       ContractSymbol contractSymbol = ContractSymbol.fromApi(event.field0.contractSymbol);
       positions.remove(contractSymbol);
     } else if (event is bridge.Event_PriceUpdateNotification) {
-      _price = Price.fromApi(event.field0);
+      price = Price.fromApi(event.field0);
       for (ContractSymbol symbol in positions.keys) {
-        if (_price != null) {
+        if (price != null) {
           if (positions[symbol] != null) {
-            final pnl = _positionService.calculatePnl(positions[symbol]!, _price!);
+            final pnl = _positionService.calculatePnl(positions[symbol]!, price!);
             positions[symbol]!.unrealizedPnl = pnl != null ? Amount(pnl) : null;
           }
         }

diff --git a/mobile/lib/features/trade/trade_screen.dart b/mobile/lib/features/trade/trade_screen.dart
@@ -113,6 +113,9 @@ class TradeScreen extends StatelessWidget {
       height: 60,
     );
 
+    bool isBuyButtonEnabled = positionChangeNotifier.price?.ask != null;
+    bool isSellButtonEnabled = positionChangeNotifier.price?.bid != null;
+
     return Scaffold(
         body: Container(
           padding: const EdgeInsets.only(left: 15, right: 15),
@@ -277,11 +280,13 @@ class TradeScreen extends StatelessWidget {
                     key: tradeScreenButtonBuy,
                     heroTag: "btnBuy",
                     onPressed: () {
-                      tradeBottomSheet(context: context, direction: Direction.long);
+                      if (isBuyButtonEnabled) {
+                        tradeBottomSheet(context: context, direction: Direction.long);
+                      }
                     },
                     label: const Text("Buy"),
                     shape: tradeButtonShape,
-                    backgroundColor: tradeTheme.buy,
+                    backgroundColor: isBuyButtonEnabled ? tradeTheme.buy : tradeTheme.disabled,
                   )),
               const SizedBox(width: 20),
               SizedBox(
@@ -290,11 +295,13 @@ class TradeScreen extends StatelessWidget {
                     key: tradeScreenButtonSell,
                     heroTag: "btnSell",
                     onPressed: () {
-                      tradeBottomSheet(context: context, direction: Direction.short);
+                      if (isSellButtonEnabled) {
+                        tradeBottomSheet(context: context, direction: Direction.short);
+                      }
                     },
                     label: const Text("Sell"),
                     shape: tradeButtonShape,
-                    backgroundColor: tradeTheme.sell,
+                    backgroundColor: isBuyButtonEnabled ? tradeTheme.sell : tradeTheme.disabled,
                   )),
             ],
           ),

diff --git a/mobile/lib/features/trade/trade_theme.dart b/mobile/lib/features/trade/trade_theme.dart
@@ -9,6 +9,8 @@ class TradeTheme extends ThemeExtension<TradeTheme> {
   static const Color green600 = Color(0xFF43A047);
   static const Color red600 = Color(0xFFE53935);
 
+  final Color disabled = Colors.grey;
+
   final Color buy;
   final Color sell;
 

diff --git a/mobile/test/trade_test.dart b/mobile/test/trade_test.dart
@@ -4,6 +4,7 @@ import 'package:flutter_test/flutter_test.dart';
 import 'package:get_10101/common/amount_denomination_change_notifier.dart';
 import 'package:get_10101/common/domain/model.dart';
 import 'package:get_10101/features/trade/candlestick_change_notifier.dart';
+import 'package:get_10101/features/trade/domain/price.dart';
 import 'package:get_10101/features/trade/order_change_notifier.dart';
 import 'package:get_10101/features/trade/position_change_notifier.dart';
 import 'package:get_10101/features/trade/submit_order_change_notifier.dart';
@@ -128,13 +129,18 @@ void main() {
 
     WalletChangeNotifier walletChangeNotifier = WalletChangeNotifier(walletService);
 
+    PositionChangeNotifier positionChangeNotifier = PositionChangeNotifier(positionService);
+
+    // We have to have current price, otherwise we can't take order
+    positionChangeNotifier.price = Price(bid: 30000.0, ask: 30000.0);
+
     await tester.pumpWidget(MultiProvider(providers: [
       ChangeNotifierProvider(
           create: (context) =>
               TradeValuesChangeNotifier(tradeValueService, channelConstraintsService)),
       ChangeNotifierProvider(create: (context) => submitOrderChangeNotifier),
       ChangeNotifierProvider(create: (context) => OrderChangeNotifier(orderService)),
-      ChangeNotifierProvider(create: (context) => PositionChangeNotifier(positionService)),
+      ChangeNotifierProvider(create: (context) => positionChangeNotifier),
       ChangeNotifierProvider(create: (context) => AmountDenominationChangeNotifier()),
       ChangeNotifierProvider(create: (context) => walletChangeNotifier),
       ChangeNotifierProvider(create: (context) => candlestickChangeNotifier)