Add support for Windows users with no WSL #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a batch version of geopython-workshop-ctl.sh for Windows users. It is as close to a direct translation of the bash script as I could manage; all commands should function identically and have identical outputs as long as Docker is properly installed.
tomkralidis
requested review from
pvgenuchten,
kalxas,
francbartoli,
justb4,
ldesousa,
PascalLike and
krishnaglodha
justb4
requested changes
Jul 17, 2024
There was a problem hiding this comment.
This is a welcome addition. Though we strongly suggest Win users to install WSL. But maybe sometimes folks don't have enough rights. In Tartu at least oneWin- participant stumbled.
Only I can't test as I don't have a Windows machine.
If we make this part of the workshop setup, then words need to be added to the intro documentation files that we start the WS with on:
https://geopython.github.io/geopython-workshop/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176.
Added
win-geopython-workshop-ctl.batfor Windows users who have not installed WSL. It is as close to a direct translation ofgeopython-workshop-ctl.shas I could manage; I believe I have tested all commands to function identically and have identical outputs as long as Docker is properly installed.I have used Windows line terminators
\r\n. Switching to Unix line terminators\nshould be done with caution, but should be OK as long as noCALLorGOTOoperators are introduced.Feel free to ping me if changes are made to
geopython-workshop-ctl.sh.