Settings + some list fixes #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matcool
reviewed
Oct 8, 2024
SMJSGaming
commented
Oct 8, 2024
| @@ -151,7 +151,6 @@ void TextInput::setCallback(std::function<void(std::string const&)> onInput) { | |||
| m_onInput = onInput; | |||
| } | |||
| void TextInput::setEnabled(bool enabled) { | |||
| m_input->setMouseEnabled(enabled); | |||
There was a problem hiding this comment.
To clarify, this caused the scroll issues in all lists and text input doesn't even use the mouse besides touches
There was a problem hiding this comment.
If setTouchEnabled is enough to make the input non-clickable then this is fine by me
SMJSGaming
commented
Oct 8, 2024
| ret->setSpriteFrames("geode-list-top.png"_spr, "geode-list-side.png"_spr, 2); | ||
| ret->setContentSize(size); | ||
| } else { | ||
| ret->setContentSize(size + ccp(5, 5)); |
There was a problem hiding this comment.
To explain this real quick, blame the fact that 90% of this asset is padding
There was a problem hiding this comment.
We love hardcoded values for dealing with weird textures
HJfod
reviewed
Oct 10, 2024
| @@ -74,12 +74,17 @@ | |||
| }); | |||
| } | |||
|
|
|||
| bool GeodeSquareSprite::init(CCSprite* top, bool* state) { | |||
| if (!CCSprite::initWithFile(isGeodeTheme() ? "GE_button_05.png"_spr : "GJ_button_01.png")) | |||
| bool isGeodeTheme(bool forceDisableTheme) { | |||
There was a problem hiding this comment.
should it though? its in the header
HJfod
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.