Fix Mac ObjC/++ autobuilds #1080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no, you are supposed to manually disable precompiled headers for objc files. geode already does this for its own files. see Line 94 in 4fa7d92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the autobuild scripts for building MacOS geode projects, and said geode project includes an Objective C or C++ file, the GitHub runner throws an error regarding the languages being disabled in the pch file but being now currently enabled. This is the fix as implemented according to cocos2d/cocos2d-x#20607 (comment), which should solve this, however I don't think I have a way to actually test it. Worth a shot, though.