Fix tests #350

ker0x · 2024-01-26T09:56:51Z

No description provided.

norkunas · 2024-01-26T10:46:32Z

I think instead of setting SYMFONY_DEPRECATIONS_HELPER: 'max[self]=3&max[indirect]=1' we could use deprecations baseline file, would be easier

norkunas · 2024-01-26T11:09:21Z

tests/allowed.json

@@ -0,0 +1,41 @@
+[


From my experience this file can change randomly when running on different devices.
I suggest this: https://symfony.com/doc/current/components/phpunit_bridge.html#ignoring-deprecations

The ignoreFile option is only available since Symfony 6.1!

phpunit.xml.dist

norkunas · 2024-01-26T11:19:52Z

tests/allowed.json

+        "message": "Since symfony/framework-bundle 5.1: Not setting the \"framework.router.utf8\" configuration option is deprecated, it will default to \"true\" in version 6.0.",
+        "count": 41
+    },
+    {
+        "message": "Since symfony/framework-bundle 6.4: Not setting the \"framework.handle_all_throwables\" config option is deprecated. It will default to \"true\" in 7.0.",
+        "count": 82
+    },
+    {
+        "message": "Since symfony/framework-bundle 6.4: Not setting the \"framework.php_errors.log\" config option is deprecated. It will default to \"true\" in 7.0.",
+        "count": 82
+    },
+    {
+        "message": "Since symfony/framework-bundle 6.4: Enabling the integration of Doctrine annotations is deprecated. Set the \"framework.annotations.enabled\" config option to false.",
+        "count": 41
+    },
+    {
+        "message": "Since symfony/framework-bundle 6.4: The \"annotation_reader\" service alias is deprecated without replacement. It is being referenced by the \"routing.loader.attribute\" service.",
+        "count": 41
+    },
+    {
+        "message": "Since symfony/framework-bundle 6.4: The \"annotation_reader\" service alias is deprecated without replacement. It is being referenced by the \"doctrine.orm.metadata.annotation_reader\" alias.",
+        "count": 5
+    }


Btw these should be fixed, not ignored ;)

.github/workflows/ci.yml

norkunas · 2024-01-29T09:28:53Z

.github/workflows/ci.yml

+              uses: actions/checkout@4
+
+            - name: "Configure Symfony"
+              run: composer config extra.symfony.require "${{ matrix.sf_version }}"

            - name: "Install Composer dependencies"
              uses: "ramsey/composer-install@v2"


Suggested change

uses: "ramsey/composer-install@v2"

uses: "ramsey/composer-install@v2"

env:

SYMFONY_REQUIRE: ${{ matrix.sf_version }}

norkunas · 2024-01-29T09:29:09Z

.github/workflows/ci.yml

+              uses: actions/checkout@4
+
+            - name: "Configure Symfony"
+              run: composer config extra.symfony.require "${{ matrix.sf_version }}"

            - name: "Install Composer dependencies"


Suggested change

uses: actions/checkout@4

- name: "Configure Symfony"

run: composer config extra.symfony.require "${{ matrix.sf_version }}"

- name: "Install Composer dependencies"

uses: actions/checkout@v4

- name: "Install Composer dependencies"

norkunas · 2024-01-29T12:39:49Z

.editorconfig

+[*.json]
+indent_size = 2
+
+[.github/**/*.yml]
+indent_size = 2


not sure what's the point of these changes if PR targets at fixing tests :) only hardens the review

Every time I modify the composer.json or the ci.yml my IDE indents the additions with 4 spaces as defined in the .editorconfig whereas they are indented with 2 spaces, these 2 lines save me from having to correct the indentation manually

Im ok with these changes but they pollute the PR, could you split into separate PR later?

norkunas · 2024-01-29T12:41:19Z

tests/allowed.json

+  {
+    "location": "Bazinga\\GeocoderBundle\\Tests\\Functional\\GeocoderListenerTest::testPersistForProperty",
+    "message": "Since doctrine/doctrine-bundle 2.11: Not setting \"enable_lazy_ghost_objects\" to true is deprecated.",
+    "count": 1
+  },
+  {
+    "location": "Bazinga\\GeocoderBundle\\Tests\\Functional\\GeocoderListenerTest::testPersistForGetter",
+    "message": "Since doctrine/doctrine-bundle 2.11: Not setting \"enable_lazy_ghost_objects\" to true is deprecated.",
+    "count": 1
+  },
+  {
+    "location": "Bazinga\\GeocoderBundle\\Tests\\Functional\\GeocoderListenerTest::testPersistForInvalidGetter",
+    "message": "Since doctrine/doctrine-bundle 2.11: Not setting \"enable_lazy_ghost_objects\" to true is deprecated.",
+    "count": 1
+  },
+  {
+    "location": "Bazinga\\GeocoderBundle\\Tests\\Functional\\GeocoderListenerTest::testPersistForEmptyProperty",
+    "message": "Since doctrine/doctrine-bundle 2.11: Not setting \"enable_lazy_ghost_objects\" to true is deprecated.",
+    "count": 1
+  },
+  {
+    "location": "Bazinga\\GeocoderBundle\\Tests\\Functional\\GeocoderListenerTest::testDoesNotGeocodeIfAddressNotChanged",
+    "message": "Since doctrine/doctrine-bundle 2.11: Not setting \"enable_lazy_ghost_objects\" to true is deprecated.",
+    "count": 1
+  },


these could be resolved with:

if (method_exists(Configuration::class, 'setLazyGhostObjectEnabled') && Kernel::VERSION_ID >= 60100) { $container->prependExtensionConfig('doctrine', [ 'orm' => [ 'enable_lazy_ghost_objects' => true, ], ]); }

ker0x · 2024-01-29T13:45:19Z

@norkunas I'm sorry, but I think I'm going to give up because there are far too many deprecations to manage with version 4.4. Every time I fix one, another pops up right after it, it's hellish!

norkunas · 2024-01-29T13:48:12Z

Sorry to hear that 😞 I'll try to complete it then

ker0x · 2024-01-30T08:34:51Z

@norkunas Holy Moly, tests are green 🥳 🎉 ! https://github.com/ker0x/geocoder-php-geocoder-bundle/actions/runs/7708347743

norkunas

I'm merging as is, but we should probably resolve some deprecations in follow up PR's because there are way too many of them :)

norkunas · 2024-01-30T08:39:21Z

Thank you @ker0x !

ker0x force-pushed the bugfix/tests branch 3 times, most recently from ff4d82c to b3d5485 Compare January 26, 2024 10:11

ker0x force-pushed the bugfix/tests branch from 1f6f607 to 5d4c457 Compare January 26, 2024 11:08

norkunas reviewed Jan 26, 2024

View reviewed changes

phpunit.xml.dist Outdated Show resolved Hide resolved

norkunas reviewed Jan 26, 2024

View reviewed changes

phpunit.xml.dist Outdated Show resolved Hide resolved

norkunas reviewed Jan 26, 2024

View reviewed changes

ker0x force-pushed the bugfix/tests branch 2 times, most recently from 13c9e58 to 0e88735 Compare January 26, 2024 13:25

norkunas reviewed Jan 26, 2024

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

ker0x force-pushed the bugfix/tests branch 14 times, most recently from 8c4725c to 090eef4 Compare January 29, 2024 09:23

norkunas requested changes Jan 29, 2024

View reviewed changes

ker0x force-pushed the bugfix/tests branch from 090eef4 to efb999c Compare January 29, 2024 10:27

ker0x mentioned this pull request Jan 29, 2024

Drop support for Symfony < 5.4, add Symfony 6.4 and PHP 8.3 to CI #342

Open

ker0x force-pushed the bugfix/tests branch from efb999c to f25715d Compare January 29, 2024 12:38

norkunas reviewed Jan 29, 2024

View reviewed changes

ker0x force-pushed the bugfix/tests branch 5 times, most recently from 4d3dfd0 to 3d1ace7 Compare January 29, 2024 13:41

ker0x force-pushed the bugfix/tests branch 8 times, most recently from 94a02d1 to 44663a7 Compare January 30, 2024 08:32

Fix tests

f479f36

ker0x force-pushed the bugfix/tests branch from 44663a7 to f479f36 Compare January 30, 2024 08:35

norkunas approved these changes Jan 30, 2024

View reviewed changes

norkunas merged commit 6c6a113 into geocoder-php:master Jan 30, 2024
14 checks passed

ker0x deleted the bugfix/tests branch January 30, 2024 09:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix tests #350

Fix tests #350

ker0x commented Jan 26, 2024

norkunas commented Jan 26, 2024

norkunas Jan 26, 2024

ker0x Jan 29, 2024

norkunas Jan 29, 2024

norkunas Jan 26, 2024

norkunas Jan 29, 2024

norkunas Jan 29, 2024 •

edited

Loading

norkunas Jan 29, 2024

ker0x Jan 29, 2024

norkunas Jan 29, 2024

norkunas Jan 29, 2024

ker0x commented Jan 29, 2024

norkunas commented Jan 29, 2024

ker0x commented Jan 30, 2024

norkunas left a comment

norkunas commented Jan 30, 2024

Fix tests #350

Fix tests #350

Conversation

ker0x commented Jan 26, 2024

norkunas commented Jan 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

norkunas Jan 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ker0x commented Jan 29, 2024

norkunas commented Jan 29, 2024

ker0x commented Jan 30, 2024

norkunas left a comment

Choose a reason for hiding this comment

norkunas commented Jan 30, 2024

norkunas Jan 29, 2024 •

edited

Loading