Refactor tests #344
Merged
Refactor tests #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkunas
force-pushed
the
refactor-tests
branch
12 times, most recently
from
052901e
to
d9d728c
Compare
- Drop dependency on `OrmTestCase` and instead use `DoctrineBundle` for setting orm automatically instead of manually; - ~~Use MockHttpClient from symfony/http-client instead of making real http calls in tests~~ Use mock Client from php-http/mock-client; - Merge CI's phpunit jobs into single one; - Separate inlined fixtures in tests to separate classes;
norkunas
force-pushed
the
refactor-tests
branch
from
d9d728c
to
dd690e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrmTestCaseand instead useDoctrineBundlefor setting orm automatically instead of manually;Use MockHttpClient from symfony/http-client instead of making real http calls in testsUse mock Client from php-http/mock-client;