Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[geocat] change logo to newer version, hide link to new version in login screen #264

Merged
merged 1 commit into from
Jun 21, 2024
Merged

[geocat] change logo to newer version, hide link to new version in login screen #264

merged 1 commit into from
Jun 21, 2024

Conversation

jahow
Copy link
Contributor

@jahow jahow commented Jun 20, 2024 •
edited
Loading

cmangeat
cmangeat reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@cmangeat cmangeat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you take b40a7f3 into account ?

gn harvester logos are configurable, the harvester logos are indeed logos of the partners which have to be credited and are of importance in this sense, you probably just have to use the admin ui to update / push the banner to use.

anyway, it should be good to let swisstopo the possibility to do it.

@Angi-Kinas
Copy link

@cmangeat thanks for the review and good point!
I think we would need to change the css (size of the picture and picture placement) to make it look nice anyway, so I would say we could leave it like this.

@cmangeat
Copy link
Contributor

cmangeat commented Jun 20, 2024 •
edited
Loading

Obviously, there is a test missing ! I.e, leave it like this would mean reopen https://jira.swisstopo.ch/browse/MGEO_SB-888.

@jahow
Copy link
Contributor Author

jahow commented Jun 21, 2024

@cmangeat I have updated the PR, can you please let me know if you approve this? Thanks

cmangeat
cmangeat approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@cmangeat cmangeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@jahow jahow merged commit d38ed55 into geocat_v4.2.3_report_custom_gracefull Jun 21, 2024
4 of 5 checks passed
@jahow jahow deleted the geocat_new_home_logo branch June 21, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmangeat cmangeat cmangeat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jahow @Angi-Kinas @cmangeat