Remove fallback getloadavg impl. #589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now it disables all checks except for checks that I have already eliminated and silenced. Signed-off-by: Alec Warner <[email protected]>
The disable list has been tweaked to disable most of the bad-style ones. Signed-off-by: Alec Warner <[email protected]>
Is there any reason to keep this fallback implementation? Signed-off-by: Alec Warner <[email protected]>
|
As I recall, the getloadavg function was added in 8607a39 due to the function being missing for python built with uclibc back then. I've found that this is still an issue with current autobuilds found in http://ftp.romnet.org/gentoo/releases/amd64/autobuilds/current-stage3-amd64-uclibc-vanilla/, for example this is with stage3-amd64-uclibc-vanilla-20200619.tar.bz2: |
zmedico
reviewed
Jul 24, 2020
| enable=redefined-builtin,useless-object-inheritance,trailing-newlines | ||
| disable=no-absolute-import,bad-continuation,C0103,C0114,C0115,E1101,W0201,no-name-in-module,W0613,C0116 | ||
| #disable=all | ||
| #enable=redefined-builtin,useless-object-inheritance,trailing-newlines |
There was a problem hiding this comment.
Maybe we should add missing-docstring in there because with pylint 2.3.1 I see a lot of errors like this:
************* Module portage.tests.util.test_file_copier
lib/portage/tests/util/test_file_copier.py:1:0: C0111: Missing module docstring (missing-docstring)
lib/portage/tests/util/test_file_copier.py:15:0: C0111: Missing class docstring (missing-docstring)
|
We're reconsidering this PR in #1383. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect this impl made sense when portage used python2.2 (which lacked it) but this function was added to the unix stdlib in python 2.3; so I think we can drop this now.