Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli option to allow running checks against a graphstore journal. #542

Merged
merged 2 commits into from
May 15, 2024

Conversation

balhoff
Copy link
Member

@balhoff balhoff commented May 14, 2024

New CLI option --check-graph-type. Fixes #541.

Copy link
Member

@kltm kltm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds a default "off" flag that will bypass certain problematic models--from the POV of QC; if "on", it will skip anything that doesn't have the appropriate data.

I just want to confirm that the -> operator is Java 8?

                    if (gocam.getAnnotations().stream().noneMatch(annotation ->
                            annotation.getProperty().getIRI().equals(graphType)

@kltm
Copy link
Member

kltm commented May 14, 2024

Noticing that tests did not pass?

@balhoff
Copy link
Member Author

balhoff commented May 14, 2024

I will look at the tests—they are unfortunately sensitive to changing external data.

@balhoff
Copy link
Member Author

balhoff commented May 14, 2024

Adds a default "off" flag that will bypass certain problematic models--from the POV of QC; if "on", it will skip anything that doesn't have the appropriate data.

I just want to confirm that the -> operator is Java 8?

                    if (gocam.getAnnotations().stream().noneMatch(annotation ->
                            annotation.getProperty().getIRI().equals(graphType)

Java 8!

@balhoff
Copy link
Member Author

balhoff commented May 14, 2024

Test failure relates to website problems at biopax.org. Fix at #543.

@balhoff
Copy link
Member Author

balhoff commented May 14, 2024

Adds a default "off" flag that will bypass certain problematic models--from the POV of QC; if "on", it will skip anything that doesn't have the appropriate data.

@kltm one thing to note—don't use this flag if testing the actual Minerva database. The models there don't have this annotation, which is inserted by the graphstore build.

@kltm
Copy link
Member

kltm commented May 15, 2024

Adds a default "off" flag that will bypass certain problematic models--from the POV of QC; if "on", it will skip anything that doesn't have the appropriate data.

@kltm one thing to note—don't use this flag if testing the actual Minerva database. The models there don't have this annotation, which is inserted by the graphstore build.

@balhoff Not that I was planning on changing the flags for our production Noctua stuff, but wouldn't that check be safe when looking at just a "TTL models only" store?

@balhoff
Copy link
Member Author

balhoff commented May 15, 2024

@kltm in a TTL models only store, all of them would get skipped if you use that flag. They won't contain the triple ?ont :graphType :noctuaCam.

@balhoff balhoff merged commit dc14000 into master May 15, 2024
1 check passed
@balhoff balhoff deleted the issue-541 branch May 15, 2024 00:19
@kltm
Copy link
Member

kltm commented May 15, 2024

@balhoff Ah, I think I understand: the trick is that they are marked in the "extended" store, but not so in the "noctua" one, and you're using that as the criteria?

@balhoff
Copy link
Member Author

balhoff commented May 15, 2024

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In some cases, minerva exits early exception when performing QC on graphstore
2 participants