Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump ontobio version to get in isoform fixes #2356

Merged
merged 3 commits into from
Aug 16, 2024
Merged

bump ontobio version to get in isoform fixes #2356

merged 3 commits into from
Aug 16, 2024

Conversation

sierra-moxon
Copy link
Member

No description provided.

@sierra-moxon sierra-moxon requested a review from kltm August 14, 2024 20:05
kltm
kltm reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@kltm kltm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but that error in the tests would seem to be a problem

@kltm
Copy link
Member

kltm commented Aug 14, 2024

Any ideas here @dustine32 ? I think this is the first time I've seen this...

@dustine32
Copy link
Contributor

I only see as high as 2.9.3 in PyPI, not 2.9.5. Maybe it's just the usual few minutes of lag between when the version is pushed and PyPI displays it?

@dustine32
Copy link
Contributor

@sierra-moxon I see the two missing versions (2.9.4, 2.9.5) in the ontobio releases page. Maybe these releases somehow didn't actually push to PyPI?

@sierra-moxon
Copy link
Member Author

yeah as per slack, I'm just getting a GH action in place in ontobio repo to push those to pypi on "release".

@sierra-moxon
Copy link
Member Author

sierra-moxon commented Aug 15, 2024 •
edited
Loading

pypi GH action worked in ontobio, bumping the available version in pypi to v2.9.6 - updated here to reflect that.

@sierra-moxon
Copy link
Member Author

@kltm - alrighty - after reverting the autopush, manual push to pypi worked well and tests here are now passing. ready when you are to try this in snapshot.

@kltm kltm self-requested a review August 16, 2024 23:27
kltm
kltm approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@kltm kltm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now passing

@kltm kltm merged commit 51d3d03 into master Aug 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kltm kltm kltm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sierra-moxon @kltm @dustine32