Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update usages of curies.Converter #88

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Update usages of curies.Converter #88

wants to merge 14 commits into from

Conversation

cthoyt
Copy link

@cthoyt cthoyt commented Nov 23, 2023 •
edited
Loading

  • more direct instantiation from prefixmaps
  • use curies implementation of rewiring
  • reduce situations where you go to a prefix map then back

@cthoyt cthoyt changed the title Reduce redundant instantiation of curies.Converter Update usages of curies.Converter Nov 23, 2023
@cthoyt
Copy link
Author

cthoyt commented Dec 4, 2023

@sierra-moxon can you please approve this PR to run CI tests?

@cthoyt
Copy link
Author

cthoyt commented Dec 5, 2023 •
edited
Loading

the last commit i made 1c26aef seemed to be addressing a spurious API issue. I just reorganized the test to give a better message while testing the same thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cthoyt