Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdpr notifications #48

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Gdpr notifications #48

wants to merge 13 commits into from

Conversation

marcos-lg
Copy link
Contributor

@marcos-lg marcos-lg requested a review from fmendezh May 18, 2018 11:35
@@ -0,0 +1,64 @@
package org.gbif.registry.cli.dataprivacynotification;

import org.gbif.common.messaging.AbstractMessageCallback;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused

package org.gbif.registry.persistence.mapper;

import java.util.List;
import java.util.Map;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused

import static org.gbif.common.messaging.api.messages.DataPrivacyNotificationMessage.EntityType;

/**
* Provides convertion from the key value pairs to HStore.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conversion or transformation

Copy link
Contributor

@fmendezh fmendezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only tiny observations

@marcos-lg
Copy link
Contributor Author

changes applied

@marcos-lg
Copy link
Contributor Author

marcos-lg commented May 24, 2018

Steps needed to release these changes:

Pending to add the email text that we want to send to the template (dataPrivacy_notification_en.ftl), now it's a sample.

Note that currently there is a cli version deployed in DEV that sends emails to my gbif email (it's hardcoded).

@MattBlissett MattBlissett force-pushed the master branch 2 times, most recently from 13d9076 to 5b30c27 Compare May 24, 2018 17:08
MattBlissett pushed a commit to MattBlissett/registry that referenced this pull request Feb 28, 2020
MattBlissett pushed a commit to MattBlissett/registry that referenced this pull request Feb 28, 2020
MattBlissett pushed a commit to MattBlissett/registry that referenced this pull request Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants