LivingAtlas: Additional fields for SpeciesListPipeline (ARGA)
#865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to GBIF latest dev
Initial commit for adding newfield `presentInCountry` set via a species list.
Refactored code to remove references to trait name in IndexRecordTransform, so only need to add new traits to IndexFields and managed-schema going forward.
Changed error to warning and a few other minor changes
ARGA-94 - ARGA list-based fields
nickdos
commented
Mar 8, 2023
| import java.util.ArrayList; | ||
| import java.util.Iterator; | ||
| import java.util.List; | ||
| import java.util.*; |
There was a problem hiding this comment.
Just noticed this - IDE did this and it might break coding rules?
djtfmartin
reviewed
Mar 24, 2023
| @@ -73,4 +74,7 @@ public interface IndexFields { | |||
| String GGBN_TERMS_LOAN = "http://data.ggbn.org/schemas/ggbn/terms/Loan"; | |||
| String LOAN_DESTINATION_TERM = "http://data.ggbn.org/schemas/ggbn/terms/loanDestination"; | |||
| String LOAN_IDENTIFIER_TERM = "http://data.ggbn.org/schemas/ggbn/terms/loanIdentifier"; | |||
| String AUS_TRAITS_FIRE_RESPONSE = "fire_response"; | |||
There was a problem hiding this comment.
Convert from snake case to camel
djtfmartin
reviewed
Mar 24, 2023
| @@ -51,6 +51,7 @@ public interface IndexFields { | |||
| String POINT_0_02 = "point-0.02"; | |||
| String POINT_0_1 = "point-0.1"; | |||
| String POINT_1 = "point-1"; | |||
| String PRESENT_IN_COUNTRY = "presentInCountry"; | |||
There was a problem hiding this comment.
Wondering why we need this. Cant the data just provide countryCode ?
There was a problem hiding this comment.
Its the field name, so data will look like presentInCountry:Australia or presentInCountry:Italy. Could use country code I suppose presentInCountry:AU but data is from region field in species list, which uses full name, so would require an additional lookup.
There was a problem hiding this comment.
I've renamed the field to taxonPresentInCountry now.
Based on feedback from Dave M. This avoids confusion with the DwC term `country`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pls assign to @djtfmartin.
PR contains changes for additional fields to be processed during the
specieslistphase of theindexpipeline. There are two set of fields that relate to:locatedInCountrya string field contains a single value, the (ISO) country name, populated via a species list. The idea being that the taxon is known to be located in that country. ARGA uses this for the large percentage of records that have no location data. Config varincludePresentInCountryhas a defaultfalsevalue.COMMON_TRAITand contain additional columns:traitNameandtraitValue. Traits defined inIndexedFields.javaand (SOLR)schema.xmlwill be indexed as multi-value but any additional lists (that are added without changes to those files) will still be indexed as dynamic fields. Config varincludeTraitshas a defaultfalsevalue.