Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CC0 notice #41

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Add CC0 notice #41

merged 2 commits into from
Sep 13, 2023

Conversation

omasanori
Copy link
Contributor

This change embeds the license notice into hardware.inc itself. No functional changes intended.

@omasanori
Add CC0 notice
3666bc8 
Signed-off-by: Masanori Ogino <[email protected]>
ISSOtm
ISSOtm approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see nothing wrong with making the document more self-sufficient when the cost is a few extra lines in the header, and it adds a machine-readable tag!

avivace
avivace approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@avivace avivace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also took the chance to add a link at the top to the repository

@avivace avivace merged commit aaef928 into gbdev:master Sep 13, 2023
2 checks passed
@omasanori omasanori deleted the cc0-comment branch September 14, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avivace avivace avivace approved these changes

@ISSOtm ISSOtm ISSOtm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omasanori @avivace @ISSOtm