Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constants from pokecrystal #32

Closed
wants to merge 15 commits into from
Closed

Add constants from pokecrystal #32

wants to merge 15 commits into from

Commits on Jun 27, 2022

  1. Update README.md 

    Fixes #16
Fixes #21
    @rawr51919
    rawr51919 authored Jun 27, 2022
    Configuration menu
    Copy the full SHA
    40030c5 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Reword the section about the release policy and the reviewer who made these suggestions

Co-authored-by: Eievui <[email protected]>
    @rawr51919 @evie-calico
    rawr51919 and evie-calico authored Jun 27, 2022
    Configuration menu
    Copy the full SHA
    9e0ffd1 View commit details
    Browse the repository at this point in the history

  3. Correct typo

    @rawr51919
    rawr51919 authored Jun 27, 2022
    Configuration menu
    Copy the full SHA
    46f7e1e View commit details
    Browse the repository at this point in the history

  4. Add intentions blurb

    @rawr51919
    rawr51919 committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    c94f0f2 View commit details
    Browse the repository at this point in the history

  5. Added in the relevant entries from ISSOtm's suggestions

    @rawr51919
    rawr51919 committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    66179df View commit details
    Browse the repository at this point in the history

  6. Separate the baseline/reference line into two lines 

    Separate the line stating the baseline and the fact that this is the new official reference

Co-authored-by: Eldred Habert <[email protected]>
    @rawr51919 @ISSOtm
    rawr51919 and ISSOtm authored Jun 27, 2022
    Configuration menu
    Copy the full SHA
    f2e346f View commit details
    Browse the repository at this point in the history

  7. Reworded the paragraph about the repo and what it's status is

    @rawr51919
    rawr51919 committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    3766cd3 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Make rev_Check_hardware_inc use SemVer

    @ISSOtm
    ISSOtm committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    9194988 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. Apply suggestions from code review 

    Most of the rewording suggestions from avivace's review implemented

Co-authored-by: Antonio Vivace <[email protected]>
    @rawr51919 @avivace
    rawr51919 and avivace authored Jul 5, 2022
    Configuration menu
    Copy the full SHA
    853d325 View commit details
    Browse the repository at this point in the history

  2. Apply ISSOtm's grammatically correct suggestion

    @rawr51919
    rawr51919 authored Jul 5, 2022
    Configuration menu
    Copy the full SHA
    4e07905 View commit details
    Browse the repository at this point in the history

  3. That was a semicolon not a colon :P

    @rawr51919
    rawr51919 authored Jul 5, 2022
    Configuration menu
    Copy the full SHA
    7996c04 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of https://github.com/gbdev/hardware.inc into g… 

    …bdev-master
    @rawr51919
    rawr51919 committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    ca3bbba View commit details
    Browse the repository at this point in the history

  5. git push origin masterMerge branch 'gbdev-master'

    @rawr51919
    rawr51919 committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    5501e2b View commit details
    Browse the repository at this point in the history

  6. Add pokecrystal constants and finish off the constants that didn't ma… 

    …ke it into 4.7.0
    @rawr51919
    rawr51919 committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    bdd7f06 View commit details
    Browse the repository at this point in the history

  7. Fix the rgbasm test

    @rawr51919
    rawr51919 committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    865f8b2 View commit details
    Browse the repository at this point in the history