Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MBC3-specific registers and values #27

Merged
merged 1 commit into from
Jun 25, 2022
Merged

Add MBC3-specific registers and values #27

merged 1 commit into from
Jun 25, 2022

Conversation

ISSOtm
Copy link
Member

@ISSOtm ISSOtm commented Jun 15, 2022

Also some minor cleanup nearby required modifications

@rawr51919 rawr51919 mentioned this pull request Jun 15, 2022
Closed
@rawr51919
Copy link
Contributor

rawr51919 commented Jun 16, 2022 •
edited
Loading

Would it be worth aiming to fix #26, #21, and fixing the macro for #16 while we're here? It's already also a good chunk of the way to fixing #8 as well
Or would it be better to address those in separate PRs?

@rawr51919
Copy link
Contributor

Also isn't rRTCLATCH supposed to be $6000?

@rawr51919 rawr51919 mentioned this pull request Jun 16, 2022
Closed
@ISSOtm
Add MBC3-specific registers and values
17541b6 
Also some minor cleanup nearby required modifications
@ISSOtm
Copy link
Member Author

ISSOtm commented Jun 16, 2022

Those other issues should be tackled as separate PRs, yes.

@ISSOtm ISSOtm merged commit 98729d0 into master Jun 25, 2022
@ISSOtm ISSOtm deleted the mbc3 branch June 25, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avivace avivace avivace approved these changes

@aaaaaa123456789 aaaaaa123456789 Awaiting requested review from aaaaaa123456789

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ISSOtm @rawr51919 @avivace