Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More human-friendly names for some constants #26

Open
ISSOtm opened this issue Apr 5, 2022 · 2 comments
Open

More human-friendly names for some constants #26

ISSOtm opened this issue Apr 5, 2022 · 2 comments
Labels
enhancement

Comments

@ISSOtm
Copy link
Member

ISSOtm commented Apr 5, 2022

Taking inspiration from pokecrystal's constants, for example. This would allow them to use hardware.inc, as well. (cc @Rangi42)
@rawr51919
Copy link
Contributor

While not impossible, it required a good chunk of constant names to be rewritten to make pokecrystal work under hardware.inc as it exists now

This was referenced Jun 16, 2022
Merged
Closed
@rawr51919 rawr51919 mentioned this issue Jul 5, 2022
Closed
@rawr51919
Copy link
Contributor

rawr51919 commented Jul 6, 2022 •
edited
Loading

Taking inspiration from pokecrystal's constants, for example. This would allow them to use hardware.inc, as well. (cc Rangi42)

PR #32 shows what a hardware.inc with those constants would look like, to me it seems kinda cluttery since a lot of the same constants are more concise as they are. Yet it's there in case others want to weigh in on this.

@ISSOtm ISSOtm mentioned this issue Nov 13, 2022
Open
@ISSOtm ISSOtm mentioned this issue Aug 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Start refactoring
Add constants from pokecrystal
3 participants
@avivace @ISSOtm @rawr51919