Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows fix #250

Merged
merged 2 commits into from
Jul 9, 2021
Merged

Windows fix #250

merged 2 commits into from
Jul 9, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jul 9, 2021

🎉 New feature

Summary

This PR is required by gazebosim/gz-launch#120

Test it

Checklist

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde added the bug Something isn't working label Jul 9, 2021
@ahcorde ahcorde requested a review from chapulina July 9, 2021 11:48
@ahcorde ahcorde self-assigned this Jul 9, 2021
@ahcorde ahcorde requested a review from caguero as a code owner July 9, 2021 11:48
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jul 9, 2021
@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #250 (a57d7db) into main (2c02538) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   89.01%   89.03%   +0.02%     
==========================================
  Files          49       49              
  Lines        4653     4653              
==========================================
+ Hits         4142     4143       +1     
+ Misses        511      510       -1     
Impacted Files Coverage Δ
include/ignition/transport/TopicStatistics.hh 100.00% <ø> (ø)
include/ignition/transport/Discovery.hh 87.94% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c02538...a57d7db. Read the comment docs.

Signed-off-by: ahcorde <[email protected]>
@chapulina chapulina added the Windows Windows support label Jul 9, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be nice to backport it at some point.

@chapulina chapulina merged commit 385d48a into main Jul 9, 2021
@chapulina chapulina deleted the ahcorde/win/fix branch July 9, 2021 16:05
traversaro added a commit to traversaro/gz-transport that referenced this pull request Aug 29, 2022
traversaro added a commit to traversaro/gz-transport that referenced this pull request Aug 29, 2022
chapulina pushed a commit that referenced this pull request Aug 29, 2022
Backport from #250

Signed-off-by: Silvio <[email protected]>

Signed-off-by: Silvio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏯 fortress Ignition Fortress Windows Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants