Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find python directly instead of using GzPython #588

Merged
merged 3 commits into from
May 22, 2024

Conversation

scpeters
Copy link
Member

🎉 New feature

Part of gazebosim/gz-cmake#350.

Summary

I suggested in gazebosim/gz-cmake#350 (comment) that we find python directly so that GzPython can be deprecated, and this is a step towards that goal.

Test it

  • Compile and run tests and verify that the check_test_ran.py script still runs.
  • Compile and run python tests and verify that they pass.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codecov is complaining about a rate limit:

Rate limit reached. Please upload with the Codecov repository upload token to resolve issue.

Otherwise, code changes looks good to me.

@scpeters scpeters merged commit cbe7c0d into main May 22, 2024
9 of 10 checks passed
@scpeters scpeters deleted the scpeters/find_python_directly branch May 22, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants