Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cmdline tests on homebrew #260

Merged
merged 2 commits into from
May 28, 2024

Conversation

Blast545
Copy link
Contributor

Summary

Disables cmdline tests that haven't passed on ign-launch2 job for homebrew, reference:
https://build.osrfoundation.org/job/gz_launch-ci-ign-launch2-homebrew-amd64/46/

I think that just adding the disable macro for the tests should be enough, but I'm following the same pattern used in #255 for consistency.

cc: @Crola1702

Checklist

  • Signed all commits for DCO
  • Added (disables) tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@Blast545 Blast545 self-assigned this May 27, 2024
@Blast545 Blast545 requested a review from nkoenig as a code owner May 27, 2024 21:20
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label May 27, 2024
@Blast545 Blast545 requested review from azeey and scpeters May 27, 2024 21:21
Signed-off-by: Jorge J. Perez <[email protected]>
@Blast545 Blast545 merged commit 837e3dc into ign-launch2 May 28, 2024
7 checks passed
@Blast545 Blast545 deleted the blast545/launch2_disable_macos_cmdline_tests branch May 28, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants