Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require cmake version 3.22.1 #396

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

scpeters
Copy link
Member

🎉 New feature

Part of #350.

Summary

We already require 22.04 in Gazebo Garden, so we can require the version of cmake from that Ubuntu version (which is 3.22.1) in our main branch, which will be used in Gazebo Ionic.

Test it

Build on 22.04, macOS, or Windows with -DBUILDSYSTEM_TESTING=ON.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Part of #350.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters merged commit 46a7cb2 into main Nov 29, 2023
8 checks passed
@scpeters scpeters deleted the scpeters/require_cmake_3_22_1 branch November 29, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants