chore: Upgrade proxy-agent #462
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@YoshiWalsh Mind taking a look at this PR or this other one that tries to address the same issue? |
|
@jariz Please review when you have a moment |
|
This change looks fine to me, but I don't have the capacity to actually test it at the moment and I'm pretty hesitant to approve something I haven't tested. |
@YoshiWalsh Would you be able to put this on another co-collaborator's radar? I think this vuln is important enough to get other people involved. |
jessdelacruzsantos
force-pushed
the
jessdelacruzsantos/update_proxy-agent_dependency
branch
from
e6496ce
to
f764208
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The current version of
proxy-agenthas the packagevm2as a dependency.vm2has a current vulnerability found here. Unfortunatelyvm2is no longer supported. The only mitigation is to upgradeproxy-agentto a version that no longer relies onvm2.I've upgraded this dependency to the latest version.
Difference
The main differences between the old and the new
proxy-agentare:ProxyAgentis an attribute of the exported packageProxyAgentinstance we no longer have to pass in the HTTP(S) proxy URL, it is retrieved from the environment variables.Issues addressed
#257