Skip to content

Commit

Permalink
will not add marginRight when gutter is 0
Browse files Browse the repository at this point in the history
  • Loading branch information
ganlanyuan committed Sep 20, 2016
1 parent bf3544e commit 702f660
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 11 deletions.
8 changes: 2 additions & 6 deletions demo/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@
tinySlider({
container: document.querySelector('.customize'),
items: 3,
gutter: 10,
controlsContainer: document.querySelector('.slider-controls'),
navContainer: document.querySelector('.thumbnails'),
lazyload: true
Expand All @@ -157,22 +156,19 @@
tinySlider({
container: document.querySelector('.non-loop'),
items: 3,
gutter: 10,
loop: false
}).init();

tinySlider({
container: document.querySelector('.slide-by-page'),
items: 3,
gutter: 10,
slideByPage: true
}).init();

tinySlider({
container: document.querySelector('.autoplay'),
items: 3,
autoplay: true,
gutter: 10,
speed: 300,
autoplayTimeout: 3000,
autoplayText: ['▶', '❚❚']
Expand All @@ -181,14 +177,12 @@
tinySlider({
container: document.querySelector('.arrow-keys'),
items: 3,
gutter: 10,
arrowKeys: true
}).init();

tinySlider({
container: document.querySelector('.auto-height'),
autoHeight: true,
gutter: 10,
items: 1
}).init();
});
Expand Down Expand Up @@ -236,6 +230,7 @@ <h2>responsive</h2>
<pre><code class="language-javascript">
tinySlider({
container: document.querySelector('.responsive'),
gutter: 10,
responsive: {
500: 2,
800: 3,
Expand Down Expand Up @@ -282,6 +277,7 @@ <h2>fixed width</h2>
<pre><code class="language-javascript">
tinySlider({
container: document.querySelector('.fixed-width'),
gutter: 10,
fixedWidth: 200,
maxContainerWidth: 900,
loop: false
Expand Down
2 changes: 1 addition & 1 deletion dist/min/tiny-slider.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/min/tiny-slider.native.js

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion dist/tiny-slider.js
Original file line number Diff line number Diff line change
Expand Up @@ -789,7 +789,9 @@ var tinySlider = (function () {
}
for (var b = sliderCountUpdated; b--;) {
sliderItems[b].style.width = slideWidth - gutter + 'px';
sliderItems[b].style.marginRight = gutter + 'px';
if (gutter !== 0) {
sliderItems[b].style.marginRight = gutter + 'px';
}
}
}

Expand Down
4 changes: 3 additions & 1 deletion dist/tiny-slider.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,9 @@ var tinySlider = (function () {
}
for (var b = sliderCountUpdated; b--;) {
sliderItems[b].style.width = slideWidth - gutter + 'px';
sliderItems[b].style.marginRight = gutter + 'px';
if (gutter !== 0) {
sliderItems[b].style.marginRight = gutter + 'px';
}
}
}

Expand Down
4 changes: 3 additions & 1 deletion src/tiny-slider.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,9 @@ var tinySlider = (function () {
}
for (var b = sliderCountUpdated; b--;) {
sliderItems[b].style.width = slideWidth - gutter + 'px';
sliderItems[b].style.marginRight = gutter + 'px';
if (gutter !== 0) {
sliderItems[b].style.marginRight = gutter + 'px';
}
}
}

Expand Down

0 comments on commit 702f660

Please sign in to comment.