Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converting hostnames to lowercase #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pldimitrov
Copy link

Case-insensitive handling of hostnames in lib/hash.c was removed in this commit 02524bf

This leads to "HOSTNAME" and "hostname" being two separate keys in the hashtable.

Hostnames are converted to lowercase when the path to the rrd file is constructed in write_data_to_rrd (gmetad/process_xml.c) so the aggregated data will likely end up in the same .rrd file anyway. However, it's more efficient to handle the hostnames in a case-insensitive manner first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant