[24.1] Fix display tags in FormSelect when available #18918
Conversation
|
Currently, the filtering will not take into account the tags, only the main "label". Did the previous component filter by tag too in the search box? Edit: I figured out we should filter by tag anyway, people might remember the tag better than the dataset name. So I'll modify the default search to include tags. |
Instead of expect the exact value, expect to contain it, since now the tags will be also displayed.
|
did you do a quick performance test for very large histories? |
|
Nope, if this was available before I just hope it shouldn't be worse than before. 😅 This is loading everything and is not (nor was) using any kind of pagination before I'm afraid. |
|
I'm worried mostly about the search, and how responsive it feels while typing. I think we have a filter worker which could be used here in case it's unresponsive. |
Ahh cool! I'm happy to use it then. I'll search for it. |
| @@ -51,19 +55,22 @@ const emit = defineEmits<{ | |||
| (e: "input", value: SelectValue | Array<SelectValue>): void; | |||
| }>(); | |||
|
|
|||
| const filter = ref(""); | |||
| const filteredOptions = useFilterObjectArray(props.options, filter, ["label", "value"]); | |||
There was a problem hiding this comment.
@ElectronicBlueberry is this what you had in mind?
Unfortunately, I cannot filter by tags because the filter expects only the keys of the object and in this case, the tags are in the sub-object "value.tags" 🤔
Fixes #18667
How to test the changes?
(Select all options that apply)
License