Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement regex validators for text workflow parameter #18781

Draft
wants to merge 12 commits into
base: dev
Choose a base branch
from

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Sep 5, 2024

Screenshot 2024-09-05 at 17 14 24 Screenshot 2024-09-05 at 17 16 49

Can't quite get the repeat to render in the editor when loading the persisted state ... but other than that I think this is functional. Will also need galaxyproject/gxformat2#105 for tests

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton
Copy link
Member

Probably is worth aligning the user facing language here with the rule builder. I used "regular expression" instead of regex throughout the frontend pieces. I think that is the right call in terms of clarify but it isn't a hill I am going to die on. I would just switch around the rule builder if you go with regex. I guess both components should be ported to use the new help terms also so we have a unified... "check out how to learn about regular expressions" blurb.

Screenshot 2024-09-06 at 11 55 03 AM

@bgruening
Copy link
Member

xref: galaxyproject/training-material#5288 (comment)

(maybe we can add regular expression to John's new help infrastructure and link to GTN?)

@mvdbeek mvdbeek force-pushed the min_max_regex branch 2 times, most recently from 74c12eb to 2c31cc1 Compare September 7, 2024 17:03
@mvdbeek
Copy link
Member Author

mvdbeek commented Sep 7, 2024

regular expression sounds good to me, but we're using the tool form builder here (for better or worse), do you see a way to embed terms here ? to the form builder this just looks like a regular text parameter.

@mvdbeek
Copy link
Member Author

mvdbeek commented Sep 8, 2024

Maybe it's time to have a regex parameter, where we can provide more help ? That concept could be extended to awk, ecmascript, python etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants