-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change import function in R #39
base: master
Are you sure you want to change the base?
Conversation
Ok the Lint R script is quite impressive but it would require a lot of changes... |
Thank you Simon! Don't hesitate to ask if we can help somewhere! Here we updated the CI workflow from Travis system to Github actions, that's why tests are different, notably considering the lint R part who allows to aply best practices to code. I don't know why the "Combine chunked test results" is failing regarding tool testing.... |
Do you have access to this file? 'All tool test results' artifact for details.
|
@sbenateau please have a look at https://rdrr.io/cran/lintr/man/exclude.html |
Thank you @bgruening this is what we need. @yvanlebras where can I edit the lint config file ? |
I now have some tests failing... I must have done something wrong with all this reformatting. |
Oh you can add |
all tests passed again in planemo :-). I will try your trick @bgruening, thank you. |
Any ideas? The reformatting of the R script seems to be ok planemo gives me no error. But I don't get the last error. |
It looks like an encoding problem... It works on my computer. |
Yes, encoding problem apparently looking at the "..residuals.." sentences |
Use data.table::fread, a more versatile function to import data. Allows the use of space, comma, semicolon as separator. Instead of only space and comma
Same as the one I cancelled but probably cleaner...