Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flacky feature static facade tests #316

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Fix flacky feature static facade tests #316

merged 1 commit into from
Aug 11, 2024

Conversation

Chemaclass
Copy link
Member

@Chemaclass Chemaclass commented Aug 11, 2024 •
edited
Loading

📚 Description

Screenshot 2024-08-11 at 12 23 29

The tests/Feature/Framework/StaticFacade/FeatureTest.php are flacky tests. Running them in isolation might help.

PHPUnit docs: https://docs.phpunit.de/en/11.3/annotations.html#preserveglobalstate

🔖 Changes

#[RunInSeparateProcess]
#[PreserveGlobalState(false)]

@Chemaclass Chemaclass added the bug Something isn't working label Aug 11, 2024
@Chemaclass Chemaclass self-assigned this Aug 11, 2024
@Chemaclass Chemaclass merged commit 68f663c into main Aug 11, 2024
12 of 13 checks passed
@Chemaclass Chemaclass deleted the fix/flacky-tests branch August 11, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusValera JesusValera JesusValera approved these changes

Assignees

@Chemaclass Chemaclass

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chemaclass @JesusValera