Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disable event listeners #315

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Fix disable event listeners #315

merged 2 commits into from
Aug 11, 2024

Conversation

Chemaclass
Copy link
Member

📚 Description

Screenshot 2024-08-11 at 12 03 15

🔖 Changes

  • Check that areEventListenersEnabled is actually true, and not just not null, because false would be also not a valid value
  • Run test_disable_class_resolver_listener in a separate process to guarantee it is not affected by any other test - and avoid flackyness"

@Chemaclass Chemaclass added the bug Something isn't working label Aug 11, 2024
@Chemaclass Chemaclass self-assigned this Aug 11, 2024
@Chemaclass Chemaclass merged commit 8eee075 into main Aug 11, 2024
12 of 13 checks passed
@Chemaclass Chemaclass deleted the fix/disable-event-listeners branch August 11, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants