Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install phpstan strict rules #313

Merged
merged 5 commits into from
Aug 10, 2024
Merged

Install phpstan strict rules #313

merged 5 commits into from
Aug 10, 2024

Conversation

Chemaclass
Copy link
Member

@Chemaclass Chemaclass commented Jun 19, 2024 •
edited
Loading

🔖 Changes

On top of PHPStan max level...

  • Add phpstan/phpstan-strict-rules
  • Enable bleedingEdge PHPStan rules

Implementing what I have learned from here https://youtu.be/AFjr3RlDOZQ by @ondrejmirtes

@Chemaclass Chemaclass added the refactoring Refactoring or cleaning related label Jun 19, 2024
@Chemaclass Chemaclass self-assigned this Jun 19, 2024
@private-packagist Private Packagist
Copy link

composer.lock

Dev Package changes

Package Operation From To About
phpstan/phpstan-strict-rules add - 1.5.5 view code - License: MIT License

Settings · Docs · Powered by Private Packagist

@Chemaclass Chemaclass marked this pull request as draft June 19, 2024 14:54
@JesusValera JesusValera marked this pull request as ready for review August 10, 2024 10:48
@JesusValera JesusValera merged commit 9ad21d6 into main Aug 10, 2024
12 of 13 checks passed
@JesusValera JesusValera deleted the feat/phpstan-strict-rules branch August 10, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusValera JesusValera JesusValera approved these changes

Assignees

@Chemaclass Chemaclass

Labels
refactoring Refactoring or cleaning related
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chemaclass @JesusValera