Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rector #308

Merged
merged 12 commits into from
Dec 23, 2023
Merged

Add rector #308

merged 12 commits into from
Dec 23, 2023

Conversation

Chemaclass
Copy link
Member

📚 Description

Install rector

Kudos for the amazing project, @TomasVotruba! 🥳

🔖 Changes

  • Apply multiple rector set rules to modernise the overall code agreements and style

@Chemaclass Chemaclass added the refactoring Refactoring or cleaning related label Dec 23, 2023
@Chemaclass Chemaclass self-assigned this Dec 23, 2023
JesusValera
JesusValera approved these changes Dec 23, 2023
View reviewed changes
Copy link
Member

@JesusValera JesusValera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

src/Console/Domain/AllAppModules/AllAppModulesFinder.php Outdated Show resolved Hide resolved
src/Framework/Bootstrap/SetupGacela.php Outdated Show resolved Hide resolved
src/Framework/Bootstrap/SetupGacela.php Outdated Show resolved Hide resolved
src/Framework/Bootstrap/SetupGacela.php Outdated Show resolved Hide resolved
src/Framework/ClassResolver/AbstractClassResolver.php Outdated Show resolved Hide resolved
@localheinz localheinz mentioned this pull request Dec 23, 2023
Merged
1 task
@Chemaclass Chemaclass merged commit f5f5186 into main Dec 23, 2023
13 checks passed
@Chemaclass Chemaclass deleted the feat/add-rector branch December 23, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusValera JesusValera JesusValera approved these changes

@localheinz localheinz Awaiting requested review from localheinz

@khru khru Awaiting requested review from khru

@antonio-gg-dev antonio-gg-dev Awaiting requested review from antonio-gg-dev

Assignees

@Chemaclass Chemaclass

Labels
refactoring Refactoring or cleaning related
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chemaclass @JesusValera