Merge pull request #300 from gacela-project/refactor-config-resolver

Remove ConfigNotFoundException
gacela-project · Jul 24, 2023 · 9c2dfc4 · 9c2dfc4
2 parents 0904541 + 681e252
commit 9c2dfc4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 37 deletions.
diff --git a/src/Console/Domain/AllAppModules/AppModuleCreator.php b/src/Console/Domain/AllAppModules/AppModuleCreator.php
@@ -4,7 +4,6 @@
 
 namespace Gacela\Console\Domain\AllAppModules;
 
-use Gacela\Framework\ClassResolver\Config\ConfigNotFoundException;
 use Gacela\Framework\ClassResolver\Config\ConfigResolver;
 use Gacela\Framework\ClassResolver\DependencyProvider\DependencyProviderNotFoundException;
 use Gacela\Framework\ClassResolver\DependencyProvider\DependencyProviderResolver;
@@ -78,17 +77,13 @@ private function findFactory(string $facadeClass): ?string
      */
     private function findConfig(string $facadeClass): ?string
     {
-        try {
-            $resolver = $this->configResolver->resolve($facadeClass);
-
-            if ((new ReflectionClass($resolver))->isAnonymous()) {
-                throw new ConfigNotFoundException($facadeClass);
-            }
+        $resolver = $this->configResolver->resolve($facadeClass);
 
-            return $resolver::class;
-        } catch (ConfigNotFoundException $e) {
+        if ((new ReflectionClass($resolver))->isAnonymous()) {
             return null;
         }
+
+        return $resolver::class;
     }
 
     /**

diff --git a/src/Framework/ClassResolver/Config/ConfigNotFoundException.php b/src/Framework/ClassResolver/Config/ConfigNotFoundException.php
diff --git a/src/Framework/ClassResolver/Config/ConfigResolver.php b/src/Framework/ClassResolver/Config/ConfigResolver.php
@@ -13,18 +13,12 @@ final class ConfigResolver extends AbstractClassResolver
 
     /**
      * @param object|class-string $caller
-     *
-     * @throws ConfigNotFoundException
      */
     public function resolve(object|string $caller): AbstractConfig
     {
-        /** @var ?AbstractConfig $resolved */
+        /** @var AbstractConfig $resolved */
         $resolved = $this->doResolve($caller);
 
-        if ($resolved === null) {
-            throw new ConfigNotFoundException($caller);
-        }
-
         return $resolved;
     }